Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes debug configuration settings for Windows SGX projects to enable proper debugging. The changes standardize runtime library settings and correct dependency references across multiple Visual Studio project files.
Key changes:
- Updated runtime library settings from static to dynamic linking variants for both debug and release configurations
- Fixed debug library dependency from
sgx_urts.libtosgx_urtsd.libfor debug builds - Added explicit project dependencies in the solution file and updated Visual Studio version metadata
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Windows/sgx/test_app/enclave/TestEnclave.vcxproj | Changed runtime libraries to DLL variants for all configurations (Win32/x64, Debug/Release) |
| Windows/sgx/test_app/app/TestApp.vcxproj | Updated SGX runtime library dependency to use debug version (sgx_urtsd.lib) for Debug configurations |
| Windows/sgx/libsgx_usgxssl/libsgx_usgxssl.vcxproj | Corrected runtime library from release to debug variant for Debug configurations |
| Windows/sgx/libsgx_tsgxssl/libsgx_tsgxssl.vcxproj | Corrected runtime library from release to debug variant for Debug configurations |
| Windows/sgx/SGXOpenSSLLibrary.sln | Updated Visual Studio version metadata and added project dependency sections |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fchinchilla
reviewed
Dec 9, 2025
jbdelcuv
reviewed
Dec 9, 2025
jbdelcuv
approved these changes
Dec 10, 2025
fchinchilla
approved these changes
Dec 10, 2025
ksandowi
commented
Feb 11, 2026
| # Visual Studio 15 | ||
| VisualStudioVersion = 15.0.28307.779 | ||
| # Visual Studio Version 16 | ||
| VisualStudioVersion = 16.0.36422.26 |
Contributor
Author
There was a problem hiding this comment.
IS there any reason why we need specific version instead of latest available?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied changes allow building Debug configuration to allow debugging on Windows